On Mon, 2009-06-22 at 13:46 -0400, Mike Frysinger wrote:
> On Mon, Jun 22, 2009 at 12:22, Philippe Gerum wrote:
> > +void __ipipe_disable_root_irqs_hw(void)
> > +{
> > +   __asm__ __volatile__ ("sti %0;" : : "d"(__ipipe_irq_lvmask));
> > +   __set_bit(IPIPE_STALL_FLAG, &ipipe_root_cpudom_var(status));
> > +}
> > +
> > +void __ipipe_enable_root_irqs_hw(void)
> > +{
> > +   __clear_bit(IPIPE_STALL_FLAG, &ipipe_root_cpudom_var(status));
> > +   __asm__ __volatile__ ("sti %0;" : : "d"(bfin_irq_flags));
> > +}
> 
> maybe just nitpicking, but could you use bfin_sti() here from irqflags.h ?

Sure.

> -mike
-- 
Philippe.


_______________________________________________
Uclinux-dist-devel mailing list
Uclinux-dist-devel@blackfin.uclinux.org
https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel

Reply via email to