ok, thanks :-)
gchen. 于 2012年12月11日 10:57, realmz paranoid 写道: > Hi Mike, > > You are right. This patch shouldn't be applied. > > -steven > > On Tue, Dec 11, 2012 at 7:55 AM, Mike Frysinger <vap...@gentoo.org > <mailto:vap...@gentoo.org>> wrote: > > On Tuesday 06 November 2012 02:29:11 Chen Gang wrote: > > the length of irq_desc_get_chip(desc)->name is not solid length > > in seq_printf, it is not suitable to use %8s. > > so change it to %s (example: "tilegx_msi" in > arch/tile/kernel/pci_gx.c) > > > > additional information: > > > > %8s limit the width, not for the original string output length > > if name length is more than 8, it still can be fully > displayed. > > if name length is less than 8, the ' ' will be filled > before name. > > > > %.8s truly limit the original string output length (precision) > > the point of this code isn't to limit to 8 chars. it's to use a > left adjust > of 8 cols so that most entries line up correctly. removing that 8 > cols means > that things won't be aligned anymore. so i don't think this patch > should be > applied. > > for example (use a fixed width font to view): > $ cat /proc/interrupts > 6: 4443 CORE Blackfin CoreTimer > 10: 0 INTN rtc-bfin > 18: 0 INTN BFIN_UART_RX > 19: 1967 INTN BFIN_UART_TX > 106: 0 ERROR EMAC_RX > NMI: 0 CORE Non Maskable Interrupt > Err: 0 > > those %8s is used to make sure the CORE/INTN/etc... take up the same > space. > if they take up a little more, that's fine, because we didn't chop it. > -mike > > _______________________________________________ > Uclinux-dist-devel mailing list > Uclinux-dist-devel@blackfin.uclinux.org > <mailto:Uclinux-dist-devel@blackfin.uclinux.org> > https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel > > -- Chen Gang Asianux Corporation _______________________________________________ Uclinux-dist-devel mailing list Uclinux-dist-devel@blackfin.uclinux.org https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel
