Hi The patch looks pretty good. It is just that it made me think of the related problem of a map-wide min/max scales that we should also address.
Jesse On Wed, Aug 19, 2009 at 3:05 PM, Jokela Pirkka <pirkka.jok...@affecto.com>wrote: > I definitely agree that you guys should read and consider the patch > before committing it. > > > > It fixes the symptom that ZoomSelection does not work with a single point > selection, but as I wrote the fix I noticed that just using ScaleUtils to > enforce the minimum zoom didn’t work. ScaleUtils doesn’t work with a point > (width == 0 && height == 0) selection – it just returns whatever envelope > was passed in to it. I wrote a comment about this and it is in the patch > file. > > > > You should consider, whether it is better to apply the patch as it is or to > fix ScaleUtils somehow. > > > > Now, I have no idea of what the ViewPortModel stuff is, but wouldn’t that > be something that goes in to ScaleUtils instead of ZoomSelection? > > > > Regards, > > > > Pirkka > > > > > > *From:* udig-devel-boun...@lists.refractions.net [mailto: > udig-devel-boun...@lists.refractions.net] *On Behalf Of *Jesse Eichar > *Sent:* Wednesday, August 19, 2009 3:25 PM > > *To:* User-friendly Desktop Internet GIS > *Subject:* Re: [udig-devel] Minimum zoom with zoom to selection, RE: (no > subject) > > > > I will get it in to uDig trunk. But I want to do this right and just once. > So we will have a quick discussion today/tonight and I will try to apply > the fix tomorrow. > > > > Jesse > > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) > http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel > >
_______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
