Thanks Jody, Point taken on the use of interceptor, I have no issue with making an EditFeatureListner it seems to have evolved into a listener anyway. I will make the changes an push my branch up some time today, the inline docs do a better job than the RFC of explaining what I was going for.
-- Levi Putna Sent with Sparrow (http://www.sparrowmailapp.com/?sig) On Wednesday, 11 July 2012 at 5:05 PM, Jody Garnett wrote: > Thanks Levi: > > This is way easier to follow rather than as a bunch of small ideas. > > The FeatureInterceptor has gotten a bit ambitious. The other interceptors we > have are used during setup and teardown (often to wire up and configure the > objects for use). > > With that in mind how about a two phase process: > - FeatureInterceptor can be used by developers to review the EditFeature when > it is first created; they can then determine if they care and hook up and > listeners they want. The focus here is on getting the write configuration of > objects in place for editing to work. The existing design with a single "run" > method will be fine for this purpose and consistent with the other > interceptors used in the uDig codebase. > - EditFeatureListener - can be a listener to whatever action the EditFeature > has going on (i.e. all the methods in your proposal look fine) > > I have taken a screen snap of the "save", "commit" and "apply" functionality; > so we can have a clean user mockup of the user-interface side of the > proposal. > > -- > Jody Garnett > > > On Wednesday, 11 July 2012 at 4:33 PM, Levi Putna wrote: > > > Hey developers, > > > > We have a RFC around edit Feature workflow that is still a work in > > progress, I wanted to submit this early to encourage community discussion > > as we refine our understanding. > > > > The over plan is it update the feature edit lifecycle to give developers > > more control over when changes are actually made, when they are committed, > > what attribute values are commutes, what attribute values are displays as > > well as provide more feedback options to the UI. > > > > The current RFC is a little rough however we will be updating it regular > > over the next few days with feedback from the list. > > > > I also have some of the interfaces stubbed out along with Java Docs that I > > will commit to a FeatureWorkflow branch to help explain what we are trying > > to do. > > > > http://udig.refractions.net/confluence/display/UDIG/Feature+editing+workflow > > > > -- > > Levi Putna > > www.ozblog.com.au (http://www.ozblog.com.au) > > > > _______________________________________________ > > User-friendly Desktop Internet GIS (uDig) > > http://udig.refractions.net > > http://lists.refractions.net/mailman/listinfo/udig-devel > > > > > > > > > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) > http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel > >
_______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
