Hi,
Benoît Audouard wrote:
Lo,
For those who want to follow the whole thread (as it's currently mostly
happening on lkml / linux-usb and usbatm ML) see :
http://lkml.org/lkml/2005/10/29/197
or
http://sourceforge.net/mailarchive/forum.php?thread_id=8843170&forum_id=5398
or
http://lists.infradead.org/pipermail/usbatm/2005-October/000671.html
http://lists.infradead.org/pipermail/usbatm/2005-November/000680.html
We follow Adrew Morton and usb maintainer comments. I believe we'll send
another version soon (tomorrow).
TODO :
- check that request_firmware_nowait work for everybody (Benoit ?)
- Greg comment : <snip> You don't need the whole GPL 2 copy here, just
put the first paragraph you have before this one in.
- Greg comment : Why do you need a header file for a single .c file?
Greg don't reply to my questions about this 2 points [1]
What's your opinions ?
To you see other blocking TODO ?
Thanks
Matthieu
[1]
> <snip> You don't need the whole GPL 2 copy here, just put the first
> paragraph you have before this one in.
>
The paragraph you quote is the BSD licence, and point 1 is :
Redistributions of source code must retain the above copyright
* notice unmodified, this list of conditions, and the following
* disclaimer
So could I remove it ?
>
> Why do you need a header file for a single .c file?
>
I think it makes things cleaner. I even like the bsd style where there
is an header for reg (hardware values) and an other for val (driver
structures).
