> Thanks for you patch for adding Devolo MicroLink modem, it will be added
> soon. It is too late for 2.6.19, but it sould be in 2.6.20.
Wonderful - thanks! :-)
> As Devolo has special usb id, we could also add a quirk that always use
> isdn firmware for this modem.
>
> Someting like
> #define IS_ISDN(sc) \
> (le16_to_cpu(sc->usb_dev->descriptor.bcdDevice) & 0x80 ||
> le16_to_cpu(sc->usb_dev->descriptor.idProduct) == DEVOLO_PID_PSTFIRM)
I'm afraid that's still no proper solution. A sticker on the product box says
"MicroLink ADSL Fun USB CH". I guess the "CH" stand for suisse and they
probably use Annex A which makes using the pots firmware a reasonable
default. A sticker on the device itself explicitly says "Annex A" which
confirms this assumption. To be even more confusing I can also find stickers
with "Engineered in Germany" and "Made in France" on them ;-).
IMHO the point is that all these Eagle chipset based devices can be used with
both Annex A and Annex B, simply by using the appropriate firmware. Thus the
user should be able to choose the firmware necessary for operation in his
country. Using the 0x80 bit for a basic autodetection is fine. But at least
the Devolo device is sold with a "suisse model number" (=> Annex A) but also
with a "germany compatibility hint" (=> Annex B). So an extra module
parameter makes sense. It should also be easy and unintrusive to introduce
it, how about:
--
#define IS_ISDN(sc) \
(pots_isdn[sc->modem_index]==2 ||
(pots_isdn[sc->modem_index]==0 &&
(le16_to_cpu(sc->usb_dev->descriptor.bcdDevice) & 0x80)))
--
I hope my concers become clear. In the end it's of course your decision. If
I've convinced you, please let me know so that I can create a proper patch.
> PS : as you have an isdn line, could you help use to select the best
> firmware ?
> Could you test all isdn firmware from
> http://atm.eagle-usb.org/wakka.php?wiki=UEagleATMDSP for eagle isdn and
> report the version (ATU-R firmware version line) and which one work
> better for you.
>
> bnm_netherlands/rtbld3i0.bnm or bnm_germany/rtbldei0.bnm should be the
> newer firmware.
I'll try this out as soon as I find time. However, the DSPei.bin firmware
worked perfectly for me (242 kByte/second on a 2 MBit/s line). What factors
do you expect to vary? Session setup time? Throughput? Others?
Cheers, Johann
_______________________________________________
Ueagleatm-dev mailing list
Ueagleatm-dev@gna.org
https://mail.gna.org/listinfo/ueagleatm-dev
