Stanislaw Gruszka wrote:
> Hallo everyone.
Hi,

> 
> I would like propose some changes to ueagle-atm driver for discusson: 
> 1) remove use_iso parameter, add alternate_setting module param 
>     to explicitly choose input pipe type: auto, bulk, isoc2,...,isoc8.
How does auto mode will work ?
Get the line speed and choose the best mode ?

I wonder if iso2 ... iso8 is really useful because nobody will know how 
to configure it.


> 2) one type (v2) of cmv firmware format, this breaks compatibility with 
>     older firmware versions but make code simpler
I am not against breaking compatibility with previous version if it make 
code better (but there should a hint if the old version is used).
Did you posted somewhere the new description of this format

> 3) NB_MODEM = 1, IMHO no one in the universe use driver with more 
>     then one device and setting module parameters for 4 devices is annoying 
I wonder, does it make lot's of difference to drop multi modem support 
(it could be used for line bonding).
Setting module parameters for 4 devices is annoying, but for one device 
it remains the same ?

> 
> Second issue is power management. What need to be done and how?
I really don't know. I think in suspend we have nothing to do (may be 
set the modem in idle state. But I expect that the power is shut-down by 
usb subsystem).
For resume, I believe we should restart the synchronization.

> Can we set modem to low power consumption state without losing 
> synchronization?
I don't think it is possible.

> How to cope with diffrent suspend mechanisms 
> (/sys/.../power/state, swsusp, suspend2)? Any ideas, comments?
I believe we have only to provide .suspend, .resume callback that will 
be called by different suspend mechanisms.



Matthieu


_______________________________________________
Ueagleatm-dev mailing list
Ueagleatm-dev@gna.org
https://mail.gna.org/listinfo/ueagleatm-dev

Reply via email to