On Wed, 23 May 2007 18:42:40 +0200, Frank Hofmann - OP/N1 RPE <[EMAIL PROTECTED]> wrote:
> Hi, > > Eric Schrock yesterday put back a change to the "wx" tool, see: > > http://www.opensolaris.org/os/community/on/flag-days/pages/2007052201/ > > Now on the UFS sources, this triggers a huge flurry of new style warnings. > > Many of which are due to the TRACE*() macros, essentially all of which are not > formatted compliant with these style guide changes. > > Now, looking at how these are used in UFS: > > - they're implemented via DTrace anyway > - UFS uses them _ONLY_ (!) as function entry/exit brackets > > Hence, they're superfluous - fbt:ufs::entry resp. fbt:ufs::return are more > than > a suitable replacement. > > I therefore propose to purge all occurances of TRACE_[0-5]() from UFS, and > remove the <sys/vtrace.h> includes. That's much easier than to reformat all > those lines... > > Any objections to the idea ? Nuke it! not used since ages. > Do I need to ARC this ? no, this use is a private implementation detail of ufs. --- frankB _______________________________________________ ufs-discuss mailing list [email protected]
