On 11/15/06, Thilo Goetz <[EMAIL PROTECTED]> wrote:
Yes, that file had tabs which made it unreadable. On the other hand, if you use Eclipse, it is not at all hard to see what changed as the structural compare will show you only logical differences.
For me, the Eclipse Java Structure Compare on SofaTest.java just tells me that testMain() and testSofaDataStream() have changed, it doesn't tell me what in those methods has changed.
We could start here: http://java.sun.com/docs/codeconv/html/CodeConventions.doc.html I don't like open braces on a line by themselves, but it's not something I would fight for.
Those conventions are good, except that they're on your side regarding the open braces. :) What do the other committers think about open braces?
I'm personally much more worried about stylistic questions that are not mere formatting. I have my compiler warnings on pretty sensitive settings, and I hate it when a source file has dozens of warnings because it makes it very hard to see real issues. For example, prefixing the use of member variables with "this" is an absolute must.
Well, I'm a constant violator of that one, as you know, having picked up the habit of prefixing member variables with 'm'. Does Eclipse have a refactor for that yet? :) I was hoping we wouldn't want to adopt any guidelines that would make large portions of our codebase in violation without any automated fix.
Another thing is the use of something like findbugs. For example, the test case I fixed opened half a dozen streams (on the same file) without closing a single one (with the effect that I couldn't just delete the file at the end of the test case). Findbugs will find that kind of issue (and has on my code, many times).
+1 to encouraging the use of FindBugs. I could use some encouraging, myself... ;) -Adam
