On 1/16/07, Adam Lally <[EMAIL PROTECTED]> wrote:
On 1/16/07, Lev Kozakov <[EMAIL PROTECTED]> wrote: > On 1/15/07, Adam Lally (JIRA) <[email protected]> wrote: > > > > PEAR Encoding Test gives NullPointerException under Sun Java 1.4.2 > > > Yes, Sun Java 1.4.2 cannot process BOM at the beginning of XML files. The > test fails in the XMLUtil.isValidXmlFile() method, because Sun's SAX parser > cannot process the UTF-8 BOM (signature). I can modify the test code to > assert that returned 'ecoding' string is not 'null'. > Hm, what should we do here? I had a similar problem with the parser Sun Java 1.4.2 not supporting XML schema validation, which we have a test case for. I changed that so the test detects that schema validation isn't supported and just returns without failing. I figured it was better to not have our test suite fail on Sun Java 1.4.2 just because a few (rarely used) features don't work. -Adam
So, should we just consider the XML encoding test not supported and return w/o a failure, if the returned 'encoding' string is 'null' ? The problem is that in the real case the PEAR installation may fail. -- Lev
