Adam Lally (JIRA) wrote:
[ https://issues.apache.org/jira/browse/UIMA-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]Adam Lally reassigned UIMA-289: ------------------------------- Assignee: Marshall Schor (was: Adam Lally) I changed your fix to instead check for the actual CasProcessorDeploymentParam is present in the list, and remove it, rather than just removing any parameter that had the same name. I think this makes more sense for an API like this. If it was going to be name-based it should have taken a String as an argument.
Your change uses == to compare the argument with the element. I think the generally expected contract for things like this is to use equals. The objects implement metadataobject - which has an equals impl which looks pretty good. Would this be better?
-Marshall
