Hi Marshall, Marshall Schor wrote: > OK. Am implementing tests and then the fixes :-)
please don't commit anything to trunk until we're done with this release. Else we might have to branch now, and I'd like to avoid that if we can. > > 2 more cases have come up: > > 1) One descriptor specifies multipleReferencesAllowed as false, the other > "omits" this. The spec says omitting is the same as false. So this > will be OK. > > 2) One descriptor specifies an element Range Type restriction, the other > doesn't specify. > I'm making this throw an exception, per the logic for #2 below in > Thilo's note. Not specifying a component type restriction is the same as specifying uima.cas.TOP. > > -Marshall > > Adam Lally wrote: >> On 8/13/07, Marshall Schor <[EMAIL PROTECTED]> wrote: >> >>> 1) Type Foo, feature Bar - range type FSArray whose element type is Baz >>> Type Foo, feature Bar - range type FSArray whose element type is >>> NotBaz >>> >>> (Should throw an exception?) >>> >>> 2) Type Foo, feature Bar - range type FSArray, whose element type is Baz >>> Type Foo, feature Bar - range type FSArray whose element type is >>> Subtype_of_Baz >>> >>> (Should be element Type = Subtype_of_Baz?) >>> >>> 3) Type Foo, feature Bar - range type FSArray with >>> multipleReferencesAllowed = false >>> Type Foo, feature Bar - range type FSArray with >>> multipleReferencesAllowed = true >>> >>> (Should throw an exception?) >>> >>> >> >> I would vote for exceptions in all three cases (agreeing with Thilo's >> logic about #2). >> >> -Adam >> >> >>
