Oops, now I know why "deepEquals()" wasn't familiar... I didn't realize it was a Java 5 thing...
This one's not critical - so I would lean toward putting it back to just plain equals. Opinions? -Marshall Thilo Goetz wrote: > [EMAIL PROTECTED] wrote: > >> Author: schor >> Date: Thu Aug 23 07:11:20 2007 >> New Revision: 569003 >> >> URL: http://svn.apache.org/viewvc?rev=569003&view=rev >> Log: >> [UIMA-534] fix equals test for Maps, also make Array tests cover >> more cases, including arrays of arrays >> >> Added: >> >> incubator/uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/resource/metadata/impl/MetaDataObject_implTest.java >> Modified: >> >> incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java >> >> Modified: >> incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java >> URL: >> http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java?rev=569003&r1=569002&r2=569003&view=diff >> ============================================================================== >> --- >> incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java >> (original) >> +++ >> incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java >> Thu Aug 23 07:11:20 2007 >> > [...] > > >> + if (val1 instanceof Object[]) return >> Arrays.deepEquals((Object[])val1, (Object[])val2); >> > > > Marshall, thanks for forcing the Java 5 issue ;-) > > Seriously, I think we've only heard positive opinions > about moving to Java 5. Our users haven't complained > either, to the contrary. If anybody has strong feelings > about being 1.4 compatible, speak up now or forever > hold your peace :-) > > --Thilo > > >
