Hi Marshall, I put my comments in-line. Overall, the approach looks good to me.
-- Tong On Fri, Feb 22, 2008 at 4:21 PM, Marshall Schor (JIRA) < [email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/UIMA-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571601#action_12571601] > > Marshall Schor commented on UIMA-816: > ------------------------------------- > > > The current approach is to have development edit manifest information in > only one place, and have that work for both maven and Eclipse building. It's good. > > That place is the maven POM for the component. Because of the visual editing capability of Manifest editor, I feel more comfortable with edting manifest.mf file. Maybe, we don't have other choices. > > > > The maven "build" operation will then generate the manifest needed by > Eclipse, and it will observe the line length restrictions, I think. It did (the max chars is about 70). > > When I look at the "Export-Package" section generated by maven build, I > do not see any long lines; when the data is long, the maven build is > splitting the line into multiple lines. The generated manifest.mf does NOT create another problem if we "view" the file. It is perfectly showed in the form-based editor. > > Can you say how you are generating the manifest file with the long > lines? To see the issue, edit something and "save" (for. e.g., remove some package from Export) . Please try with uimaj-ep-runtime plug-in as follows: 0. Open plugin.xml 1. Remove "example" from Exported Pakage in "Runtime" tab 2. Go to source of MANIFEST.MF. Eclipse does some formattings. No error yet ! 3. Save the file. Go to source of MANIFEST.MF. There is a "red" dot at the first line that has lenght more than 512 (is there any magic number here ?).
