Michael Baessler wrote:
Marshall Schor wrote:
Here's the next batch of things I've noticed about the annotator release.
In the main uima build, doing a mvn install mutliple times doesn't cause
the docbook PDF generation to be re-run (if the source hasn't changed),
but in the sandbox distr, it does. (Haven't investigated why).
We have to investigate why, maybe something related to the PEAR packaging we
do, but is this an
issue that has to be solved for the current release?
In my opinion, this doesn't need to be fixed for this release. My guess
is that the ant builds for these docs have hardcoded an always executed
"clean" step.
The POM for DictionaryAnnotator (and probably many others) has
<dependency>
<groupId>org.apache.uima</groupId>
<artifactId>PearPackagingMavenPlugin</artifactId>
<version>2.2.2-incubating</version>
<scope>package</scope>
</dependency>
I couldn't find "package" as a valid scope value. The maven 2 docs at
http://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope
say there are 5 scopes available, and "package" is not one of them.
Should this be something else? Something is causing the eclipse:eclipse
to put in a bunch entries under "Referenced Libraries" that look like
they don't belong, such as :plexus-utils-1.1.jar.
I choose package since it is just used to create the PEAR package for the
component. I think the
dependencies are caused by the Maven plugin.
But "package" doesn't appear to be a valid choice - the only choices
listed (according to the above documentation) are :
compile, provided, runtime, test, system and import.
If you found some documentation somewhere which says "package" is a
valid scope, can you post where, so I can learn about it?
The Dictionary Annotator has a jar, dict_annot_xml_types.jar. I
couldn't easily find out where / how this jar is built, or maintained.
Is that documented somewhere in the project? I don't think we want to
ship something that includes a jar that is not buildable from source...
(After some investigation - I'm beginning to think it's related to
xmlbeans? If so, is there a step that maintainers of this code need to
know about to build things using the xmlbeans package?)
That jar also has package names that start with "org.apache.incubator"
- this seems incorrect - I think the practice is to have package names
not include "incubator" so that when graduation happens, package names
don't need to change.
The dict_annot_xml_types.jar jar is a generated jar when using XML Beans. Right
the package name
org.apache.incubator is not perfect, but the packages are only internally used
by the
DictionaryAnnotator. We could change this easily without any impact for the
user.
Do you think this must be changed for the current release.
If this is internal, I don't think this needs fixing for this release.
Can you also remember to add some documentation for future maintainers
on how to use/build xmlbeans (unless of course, it's already present,
and I just missed it...)
-Marshall
