Sounds good to me. --Thilo
Adam Lally wrote: > FYI, a while back I posted some code we could consider adding for JCAS > that allow you to get iterators parameterized by specific JCAS types: > http://www.mail-archive.com/[email protected]/msg04657.html > > It might be interesting to consider adding something like that > directly on the JCAS interface. > > -Adam > > On Tue, Jun 9, 2009 at 4:52 AM, Jörn Kottmann<[email protected]> wrote: >> Thilo Goetz wrote: >>> Jörn Kottmann wrote: >>> >>>> Hello, >>>> >>>> right now every FSIndex uses FeatureStructure as the generics parameter >>>> for >>>> the Iterator it can provide. That means that the AnnoationIndex also >>>> must provide >>>> an FeatureStructure Iterator and not an AnnotationFS Iterator which >>>> would be much >>>> nicer in client code. >>>> >>>> I would like to suggest to change the generic parameter of the Iterator >>>> to >>>> ? extends FeatureStructure, then AnnotationIndex can reduce it to >>>> AnnotationFS. >>>> >>>> Would do others think ? >>>> >>> +1 >>> >> Its now checked in. >> >> Maybe you can have a look at it: >> http://svn.apache.org/viewcvs?view=rev&rev=782908 >> http://svn.apache.org/viewcvs?view=rev&rev=782914 >> >> Jörn >>
