The generification of FSIndex currently specifies one type, <T extends
FeatureStructure> that is the type of item being returned.


The contains and find methods have arguments of type FeatureStructure. 
These could be changed to take type "T".

I think the current implementation has maybe a bug - if you use contains
or find methods, and pass in Feature Structures whose types are not a T
or a subtype of T, the index comparator code (I think) doesn't check if
the argument is of the right type, and just presumes it can ask for
feature values from the type to use in the testing.

So it would be an improvement to require that these arguments be <?
extends T>, I think.

The compare is similar - I think both args should be <? extends T>

Other opinions?

-Marshall

Reply via email to