Olivier Terrier (JIRA) wrote: > [ > https://issues.apache.org/jira/browse/UIMA-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Olivier Terrier updated UIMA-1506: > ---------------------------------- > > Attachment: BSFAnnotator.zip > > Marshall: I did a quick review of the code to: > 1. Fix the NullPointerException when running the testAnnotatorAggregated > 2. migrate the BSFAnnotator from the old-way JTextAnnotator_ImplBase to > JCasAnnotator_ImplBase > 3. add a few generics to avoid warnings > > Attached you will find a zip that contains the files that have been modified > Thanks, Olivier; I applied the changes and will check them in soon.
One question: The POM for this project specifies that the Jar have included "resources", which then become available on the class path. The resources included are BeanshellTestAnnotator.xml BSFAggregatedAE.xml BSFAnnotator.xml NICKNAMES.bsh RhinoTestAnnotator.xml TEST.bsh TEST.js Should all of these be packaged in the Jar by the build step? I guess I don't understand the reason these should be in the Jar. The resources org.apache.uima.annotator.bsf.BSFAnnotatorMessages_fr.properties org.apache.uima.annotator.bsf.BSFAnnotatorMessages.properties are also included, but these I believe do belong in the Jar. Thanks for your advice :-) -Marshall
