Rico Landefeld wrote: > I don't agree. There are also NotNullPredicates used in the > AnnotationTokenStream class, which avoid null checks of iterator > values. This is a really nice feature to clean up the code because > iterators are heavily used in this class. > > Rico
I don't care either way. I'll update the notice file to be correct for the current version of Lucas, i.e., with the google collections stuff. If at some future point we decide to do without it, we'll just have to remember to take the mention out of the notice file. --Thilo > > On Thu, Sep 3, 2009 at 5:13 PM, Marshall Schor<m...@schor.com> wrote: >> >> Thilo Goetz wrote: >>> The NOTICE file for Lucas currently does not list any >>> external dependencies. However, looking at Lucas after >>> it's been built, it seems to me we'll be shipping the >>> google-collections.jar. Is that correct? We ship >>> everything that ends up in lib, and nothing else? >>> >> I think so. There's already a Jira issue for fixing this: >> http://issues.apache.org/jira/browse/UIMA-1534 " >> >> >> Lucas build puts third-party jars into lib dir - need to review >> Licenses and update Notices for these" >> >> The Jira notes there are other things besides google collections: >> including lucene-snowball and lucene-core. >> >> -Marshall >> >>> Thanks, >>> Thilo >>> >>> >>>
