Comment #2 on issue 169 by limodou: A big one
http://code.google.com/p/ulipad/issues/detail?id=169
I think there are some problems about your patch:
1. You can see #161, the original caption is "Recent Files...", and you
suggested me
to change it to "Rencent Documents", and this time, you want me to change
it back?
2. You want to change "Can't open the file [%s]." to "Can't open the file
in the path
%s.", I think it's not right, because it's indeed filename but not path.
3. You want to change
{{{
if wx.Platform == '__WXMSW__':
from modules import winreg
for v in ('2.3', '2.4', '2.5', '2.6', '3.0'):
try:
key = winreg.Key(winreg.HKLM,
r'SOFTWARE\Python\Pythoncore\%s\InstallPath' % v)
interpreters.append((v+' console', os.path.join(key.value,
'python.exe')))
interpreters.append((v+' window', os.path.join(key.value,
'pythonw.exe')))
except:
pass
}}}
to
{{{
if sys.platform == 'win32':
from modules import winreg
for v in ('2.3', '2.4', '2.5', '2.6', '3.0'):
try:
key = winreg.Key(winreg.HKLM,
r'SOFTWARE\Python\Pythoncore\%s\InstallPath' % v)
interpreters.append((v+' console', os.path.join(key.value,
'python.exe')))
interpreters.append((v+' window', os.path.join(key.value,
'pythonw.exe')))
except Exception:
pass
}}}
I think they are almost the same, and I'll not change it.
4. "Uses tab as indent char or uses space as indent char." to "Uses a tab
as an
indent character or uses a space as indent character.", I think we don't
need to
indicate the number of character, and the number of space can be set in
preference,
and default is 4, but not one. So I'll change it to "Uses tabs as indent
characters
or uses spaces as indent characters.". And here the menu caption will be
changed with
the indent status changed.
5. "Command line of Open Command Window Here:" to "Path to the command-line
interface
of Open Command Window Here:", why I don't want to change it? Because
command line is
not just a path, but also including the parameters of it, so only path is
not
correct.
6. I think "The file" is better than "That file".
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
