---------- Forwarded message ----------
From: Luis A. Bastiao Silva <[EMAIL PROTECTED]>
Date: Sat, Sep 20, 2008 at 9:25 AM
Subject: Re: [umit-devel] OS match bug
To: Adriano Marques <[EMAIL PROTECTED]>




 On Sat, Sep 20, 2008 at 7:42 AM, Adriano Marques <[EMAIL PROTECTED]>wrote:

> Hello,
>
> >> And if I have two or more osmatch with accuracy 90%? (it's only a
> example)
> >> So in my opinion it doesn't make sense. If we want better software in my
> >> opinion you should adapt it and create a nice intuitive.
> >> We don't have totally sure about a operation system. But we have a list.
> >> So I invite you to think in something.
>
> Well, we can't show an icon for each match. That would decrease our
> usability. Also, sometimes when we show the host, we use it's os icon
> in front of it, so after a match we need to pick one to represent it.


It's higher accuray. get_osmatch with patch returns higher accuracy os.



>
> The solution would be, showing in the interface a combo list, which
> shows by default our automatically chosen match (let's say, the first
> with higher accuracy in the XML) and the interface shows the icon that
> represents that match. If the user find that the representation and
> the match are wrong, then he can click the combo box and select
> another match from the list. Then, the icon must follow the change,
> and we need to persist this choice in our usr file when saved.


Forget icons. I'm totally agree with select icon from higher accuracy.
But I'm not agree with discard others osmatch.
In my opinion it should be appear on a list with other possibilites to
detected OS in a List or something like that with a tuple (Name, Accuracy).
That's only my point. :)


>
>
> > Check patch: http://www.kop-labs.com/umit/patch/osmatches.diff
>
> Your patch looks ok, but I would hold him for a little while, as it
> can change after the GUI modifications. You might find that you need
> something else, or that you need something less in that code.


I din't change the goal of code. I just added a new function that returns
list of osmatches.
So, may be we can use that with idea above.

Shoud I commit the patch?


>
>
>
> Kind Regards,
>
> --
>  Adriano Monteiro Marques
>
> http://adriano-marques.blogspot.com
> http://umit.sourceforge.net
> [EMAIL PROTECTED]
>
> "Don't stay in bed, unless you can make money in bed." - George Burns
>



Kind Regards,
-- 
Luis A. Bastiao Silva




-- 
Luis A. Bastiao Silva
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Umit-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/umit-devel

Reply via email to