Great news :) By the way I don't find any button on the toolbar to
trigger the fullscreen functionality. So I suggest Kasina to add
something like that for a better usability.
Other bugs I've found by taking a brief look into your code. First of
all the use of check_finished function of the sniff context, in
__check_for_packets method (file chart.py). That function is only
intended for scapy SniffContexts. So you have to remove that line,
since your code could raise an exception if the context is a simple
StaticContext, or if you're using UMPA backend.
Next bug is located at line 164 responsible for the calculus related
to the zoom operation. Sometimes the division raises a
ZeroDivisionError. This is what i get on my console:
Traceback (most recent call last):
File "/home/stack/workspace/MSC/msc.ump/bin/chart.py", line 109, in
do_expose_event
File "/home/stack/workspace/MSC/msc.ump/bin/chart.py", line 164, in
__cairo_draw
ZeroDivisionError: float division
TypeError: do_expose_event() takes exactly 3 arguments (2 given)
About the do_expose_event, I guess you're connecting signals in a
wrong way. In pygtk every class that inherits a widget class and
defines a custom __gtype_name__, doesn't have to connect standard
signals at all. I mean at line 54 you're doing:
self.connect('expose_event', self.do_expose_event)
This is not necessary at all. Just drop that line and modify the
do_expose_event method in this way:
def do_expose_event(self, evt): # Without the widget variable as you did
Other problem I've found is in the setup.py. It raises an exception
related to the unicode string that cannot be converted into ASCII. I'd
recommend you to use unicode string representation. So you should have
something like u'Luís A. Bastião Silva' and not 'Luís A. Bastião
Silva'.
I know I'm too strict, but there's the last thing related to the
source code file. I'm currently using vim for editing my files and
I've set up it to show me trailing white spaces as red colored lines.
Well while opening your files I see plenty of trailing spaces. So take
care of dropping useless spaces.
Another point that I would take in account is the use of 'print' in
your code. Well as you may know this keyword is going to be changed in
py3k. Furthermore I discourage the use of this function in the code,
and I recommend you to move in other directions. For example, you
could use the umit.pm.core.logger.log object. In this way it will be
easy for you and also for the end-users to exclude certain log lines
matching the PM_LOGEXCLUDE regex, or to set a reasonable log-level by
using PM_LOGLEVEL.
Hope this long email will help you in doing better!
--
Best regards,
Francesco Piccinno
2010/6/15 Abhiram Kasina <[email protected]>:
> Hey all
>
> This is the list of features we would like to see in the future for MSC.
> http://trac.umitproject.org/wiki/MessageSequenceCharts
>
> Let me know what you all think
>
> Thanks
> Kasina.
>
> On Tue, Jun 15, 2010 at 7:22 AM, Luis A. Bastiao Silva <[email protected]>
> wrote:
>>
>> Hi guys,
>> Niteesh Kumar had sent a patch for Messages Sequence Charts. Now it has a
>> Fullscreen mode feature.
>> Can you guys take a look?
>> The fullscreen mode works as expected in Mac OS. It just had some problems
>> in leave fullscreen mode.
>> "Known bug: plugin gets resized when you leave full screen." by Niteesh
>> Kumar
>> You should remove it from fullscreen windows after destroy it.
>> @Kasina: could you give some extra missing features in the plugin? Please
>> write it in Wiki page and post us the link.
>> Thanks Niteesh! You're welcome.
>> Best Regards,
>> --
>> Luís A. Bastião Silva
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Umit-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/umit-devel
