This time I'll include the patch, heh
> 
> I finally got around to syncing with cvs and rebuilding the patch.
> 
> >
> > >   2) "@Echo off" needs to go after the initial comment block in the
> > >      file; otherwise, install.pl will miss the "OPTIONAL" line when
> > >      offering which scripts to install.  This is arguably a bug in
> > >      install.pl...  But I kind of like having the top-level
> > >      description of the script appear first in the file.  I am pretty
> > >      sure the "::" lines do not echo anyway.
> >
> > True, the "::" lines do not echo.
> > I have no problem with moving the @Echo off to under the 1st comment block.
> >
> > Should I resubmit the patch with the Echo statements moved? I'll look into doing 
> > this sometime
> > tomorrow if need be.
> >
> > >
> > > Other than these minor things, the question is, what do other people
> > > think?  You have a good point about todo.pl already being fairly
> > > verbose about what it is doing...  Do people like the current output,
> > > which prints something whenever a command gets pushed on the to-do
> > > list, as well as when it gets popped off?  Or are "quieter" scripts
> > > better?
> >
> > > I am leaning toward applying these "quieting" patches unless somebody
> > > wants to talk me out of it.
> > >
> > >  - Pat

Attachment: Unattended-Add-Echo-Off-to-Scripts-patch.diff
Description: Binary data



Reply via email to