On Sun, Feb 08, 2009 at 05:08:15PM +0100, Juan Jose Pablos wrote:
> Allan Lyons escribió:
>
> > 3) remove what I think is the last remaining bashism so the makefile works
> > on systems where /bin/sh is a POSIX compliant
> > shell other than bash. Brace expansion is a bash extension.
> >
> sorry, explain yourself a bit more . I only see a patch that tidy up the
> copy file stuff.
Yes, it doesn't do much.
What this patch does is to change the syntax from something that only bash
understands to something that all posix compliant shells
should understand. make uses /bin/sh to run the commands. On Debian Lenny and
recent/future Ubuntu releases, bin/sh is dash and not
bash. This should be functionally equivalent and work no matter what /bin/sh
is.
Allan.
Index: Makefile
===================================================================
RCS file: /cvsroot/unattended/unattended/linuxboot/Makefile,v
retrieving revision 1.199
diff -u -r1.199 Makefile
--- Makefile 6 Feb 2009 12:20:44 -0000 1.199
+++ Makefile 8 Feb 2009 04:05:34 -0000
@@ -393,11 +396,9 @@
cd $(kbd) \
&& make DESTDIR=$(cwd)/stage1 install
rm -rf stage1/usr/share/locale
- rm stage1/usr/bin/{deallocvt,dumpkeys,fgconsole,getkeycodes} \
- stage1/usr/bin/{kbdrate,loadunimap,mapscrn} \
- stage1/usr/bin/psf*table \
- stage1/usr/bin/{resizecons,setkeycodes,setleds} \
- stage1/usr/bin/{setmetamode,showconsolefont,showkey}
+ cd stage1/usr/bin && rm deallocvt dumpkeys fgconsole \
+ getkeycodes kbdrate loadunimap mapscrn psf*table \
+ setkeycodes setleds setmetamode showconsolefont showkey
[ -e $@ ]
stage1 += stage1/bin/loadkeys
------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
_______________________________________________
unattended-devel mailing list
unattended-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/unattended-devel
