Hello everyone,

is there good reason to include always "Requires: python" in
libunbound.pc, when --with-pythonmodule --with-pyunbound configure flags
are used? I want to build python3 only version in Fedora. I can use
PYTHON=python3 to choose different python. But I found no way to change
default pkg-config libunbound requires. In Fedora there is different
pkg-config files for python2 and python3. I checked Debian uses
different directories, both has got minor versions as well.

I filled a new bug for it:
https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=4109

I would like to ask though. Is it even useful to export python library
and flags in pkg-config? In what cases would I need these libraries? I
think it is used only to build python native _unbound.so library. Is it
expected to link against this library? It is not so versioned, it seems
private to me. I removed these flags in Fedora and no one complained. I
think it should be removed or at least moved into Requires.private:
section. Am I missing something important?

Thanks!

-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: [email protected]  PGP: 65C6C973
From ff26799a97ecede860bf045bcfc3f7c79684061e Mon Sep 17 00:00:00 2001
From: rpm-build <rpm-build>
Date: Tue, 26 Jun 2018 19:08:45 +0200
Subject: [PATCH 2/2] Do not export python from pkg-config.

---
 unbound-1.7.0/contrib/libunbound.pc.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/unbound-1.7.0/contrib/libunbound.pc.in b/unbound-1.7.0/contrib/libunbound.pc.in
index 130bef5..f266388 100644
--- a/unbound-1.7.0/contrib/libunbound.pc.in
+++ b/unbound-1.7.0/contrib/libunbound.pc.in
@@ -7,7 +7,8 @@ Name: unbound
 Description: Library with validating, recursive, and caching DNS resolver
 URL: http://www.unbound.net
 Version: @PACKAGE_VERSION@
-Requires: libcrypto libssl @PC_LIBEVENT_DEPENDENCY@ @PC_PY_DEPENDENCY@
+Requires: libcrypto libssl @PC_LIBEVENT_DEPENDENCY@
+Requires.private: @PC_PY_DEPENDENCY@
 Libs: -L${libdir} -lunbound
 Libs.private: @SSLLIB@ @LIBS@
 Cflags: -I${includedir} 
-- 
2.14.4

Reply via email to