> (please don't drop the public list/archive address from the Cc:)

Whoops, sorry, my bad.

On Thu, Dec 8, 2016 at 5:55 PM, Eric Wong <[email protected]> wrote:
> (please don't drop the public list/archive address from the Cc:)
>
> Josh Morrow <[email protected]> wrote:
>> Eric Wong <[email protected]> wrote:
>> > Fwiw, we switched to checking stdin last year so SIGWINCH could
>> > be usable with foreman and other process managers:
>>
>> In foreman `$stdin.tty?` returns `true`. In ForeGO it returns `nil` : (.
>
> `nil` or `false`?  With how unicorn uses it, it doesn't matter,
> but it should really be `false` there based on reading the
> rb_io_isatty function in io.c of the MRI source.
>
> But anyways, I suspect ForeGO redirects the stdin to /dev/null
> (you can check with lsof); which is totally reasonable for
> running daemons.
>
> That is why I recommended the before_fork workaround to
> trap(:WINCH, "DEFAULT") to restore the default noop behavior.

Reply via email to