I've put ccc-tcp-v3 in production today--it appears to be working as expected, still rejecting at the exact same rate as before (100-200 per second for us during steady-state).
On Wed, Mar 8, 2017 at 7:06 AM, Simon Eskildsen <[email protected]> wrote: > Patch-set looks great Eric, thanks! > > I'm hoping to test this in production later this week or next, but > we're a year behind on Unicorn (ugh), so will need to carefully roll > that out. > > On Tue, Mar 7, 2017 at 7:26 PM, Eric Wong <[email protected]> wrote: >> Eric Wong <[email protected]> wrote: >>> Simon Eskildsen <[email protected]> wrote: >>> > @@ -28,6 +29,7 @@ class Unicorn::HttpParser >>> > # Drop these frozen strings when Ruby 2.2 becomes more prevalent, >>> > # 2.2+ optimizes hash assignments when used with literal string keys >>> > HTTP_RESPONSE_START = [ 'HTTP', '/1.1 '] >>> > + EMPTY_ARRAY = [].freeze >>> >>> (minor) this was made before commit e06b699683738f22 >>> ("http_request: freeze constant strings passed IO#write") >>> but I've trivially fixed it up, locally. >> >> And I actually screwed it up, pushed out ccc-tcp-v2 branch >> with that fix squashed in :x >> >> Writing tests, now...
