[email protected] wrote:
Thanks, patch looks good; though I'd like to confirm
some things below for the sake of documentation.
> The `EPERM` error gets raised by the Linux kernel if:
> ```
> (too_many_pipe_buffers_hard(pipe->user) ||
> too_many_pipe_buffers_soft(pipe->user)) &&
> !capable(CAP_SYS_RESOURCE) && !capable(CAP_SYS_ADMIN)
> ```
Which kernel are you running?
Modern kernels prefix that condition with:
if (nr_pages > pipe->buffers &&
Scanning kernel changes with `git log -p -L:pipe_set_size:fs/pipe.c',
I see that check was added in b0b91d18e2e97b741b294af9333824ecc3fadfd8
("pipe: fix limit checking in pipe_set_size()")
which was fixed in Linux v4.9+ and v3.16.57+
https://80x24.org/mirrors/linux.git/commit?id=b0b91d18e2e97b741b294af9333824ecc3fadfd8
https://lore.kernel.org/lkml/?q=s%3A%22fix+limit+checking+in+pipe_set_size%22
> Given that the resize is not strictly necessary Unicorn should
> rescue the error and continue booting.
Agreed. Applied, tested and pushed to master as
commit 5c613c6ea98541df587193e861364c858a8a0abd
Thanks!
Will tag and release v5.5.1 in a day or two.
--
unsubscribe: [email protected]
archive: https://bogomips.org/unicorn-public/
