Jean Boussier <[email protected]> wrote: > Ruby just recently bump the master version to 3.0 and this > version requirement in unicorn breaks our ruby-head CI.
Thanks for the note. Something to that effect should be in the commit message body. > I don't really see any reason to protect against newer Ruby version. I do: Ruby does not have a good track record when it comes to maintaining backwards compatibility. I no longer start new projects in Ruby as a result. If 3.0 seems OK (we won't be certain until December), then bumping it to "< 4.0" should be acceptable for now. Hint: you can make maintainers' life slightly easier by adding a "--8<--\n" line before the patch, so "git am --scissors" works :> (the "From " line is also unnecessary) > From d1c43dd70b06543727ac88e3930caa0482558a6b Mon Sep 17 00:00:00 2001 > From: Jean Boussier <[email protected]> > Date: Tue, 1 Sep 2020 14:14:07 +0200 > Subject: [PATCH] Update ruby_version requirement to allow ruby 3.0 As noted above, something along the lines of ruby.git being on 3.0 and our current code being compatible with it is necessary, here. > --- a/unicorn.gemspec > - # technically we need ">= 1.9.3", too, but avoid the array here since > - # old rubygems versions (1.8.23.2 at least) do not support multiple > - # version requirements here. I prefer we keep that above comment, too, to keep working with older rubygems. Thanks. > - s.required_ruby_version = '< 3.0' > + s.required_ruby_version = '>= 1.9.3' -- unsubscribe: one-click, see List-Unsubscribe header archive: https://yhbt.net/unicorn-public/
