Jean Boussier <[email protected]> wrote:
> >> Ok, so the linking issues were simply me being silly. I forgot
> >> to run `make ragel` and commit the output (to use a git gem).
> >> Unicorn now run just fine under 3.0.0-dev (current master).
> > 
> > Odd, just "make" (no args) should work.
> 
> It does, but the files it generates are in .gitignore, and I was
> trying to use the gem through bundler's git gems. Anyway,
> now I know the drill.

Ah, perhaps adding some checks to extconf.rb would be useful?
Or moving the ragel invocation into the extconf.rb-generated
Makefile? (not too sure how to do that...).

I'm not remotely knowledgeable when it comes to bundler.

> > Anything else in the ruby 3.0 pipeline that might introduce
> > incompatibilities?
> 
> Not that I know of. There not any big breaking change
> planned for 3.0. 

Good to know.

> > Not sure if releasing unicorn 5.7 is worth doing soon/now or
> > closer to December 25...
> 
> It is up to you. But the sooner the better for me. We run
> our master branch CI against ruby master on a nightly
> basis. Until this patch is released I'll have to keep a fork
> around.

OK, soon.  Maybe with just the aforementioned ragel check above;
or not even...  Electric grid is failing and public libraries
are all closed due to COVID-19; so net access can be scarce.
--
unsubscribe: one-click, see List-Unsubscribe header
archive: https://yhbt.net/unicorn-public/

Reply via email to