This is still the ->page_mkwrite bug, yes? I’ve fixed it a few days ago and pushed new git repos (the patches online haven’t been updated yet).
Cheers, Erez. On May 14, 2014, at 3:12 PM, James Davidson <[email protected]> wrote: > On Wed May 14, 2014 at 06:06:02AM -0700, Theodore Ts'o <[email protected]> wrote: >> On Tue, May 13, 2014 at 11:15:56PM -0400, Theodore Ts'o wrote: >>> We're seeing a number of ext4 BUG_ON's when using unionfs. They can >>> be triggered using fsx, so we've seen it with xfstests generic/074, >>> generic/112, generic/127, and generic/198, for example. None of these >>> tests are failing if we use ext4 w/o unionfs. >> >> And here's an even simpler repro case. Again, this works just fine >> w/o unionfs. > > The sample program also causes a BUG_ON in 3.10.40 w/ unionfs 2.5.13 > > [ 228.209977] ------------[ cut here ]------------ > [ 228.211687] kernel BUG at fs/ext4/inode.c:2364! > [ 228.212996] invalid opcode: 0000 [#1] SMP > [ 228.214512] Modules linked in: unionfs ipv6 loop hid_generic usbhid hid > processor thermal_sys evdev serio_raw intel_agp freq_table psmouse > virtio_console virtio_balloon i2c_piix4 i2c_core intel_gtt agpgart microcode > pcspkr button pata_acpi ata_generic virtio_blk virtio_net floppy virtio_pci > virtio_ring virtio ata_piix > [ 228.219291] CPU: 0 PID: 1922 Comm: mmap-write Not tainted > 3.10.40-1-amd64-vyatta #1 > [ 228.219291] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 > [ 228.219291] task: ffff88003e2b94a0 ti: ffff88002f85c000 task.ti: > ffff88002f85c000 > [ 228.219291] RIP: 0010:[<ffffffff8119fe60>] [<ffffffff8119fe60>] > write_cache_pages_da+0x470/0x480 > [ 228.219291] RSP: 0018:ffff88002f85dbc8 EFLAGS: 00010246 > [ 228.219291] RAX: 000000000000000c RBX: ffff88002f85dd58 RCX: > 001ffc0000000019 > [ 228.219291] RDX: 0000000000000000 RSI: ffff88002f85db58 RDI: > ffff8800318ad320 > [ 228.219291] RBP: ffff88002f85dc40 R08: 0000000000000001 R09: > 0000000000000100 > [ 228.219291] R10: 0000000000001000 R11: 0000000002000000 R12: > ffff8800318ad320 > [ 228.219291] R13: ffff88002f85ddd0 R14: ffffea0000b4da00 R15: > 0000000000000000 > [ 228.219291] FS: 00007f12e934e700(0000) GS:ffff88003fc00000(0000) > knlGS:0000000000000000 > [ 228.219291] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b > [ 228.219291] CR2: 00007f12e9354000 CR3: 000000002fa7d000 CR4: > 00000000000006f0 > [ 228.219291] DR0: 0000000000000000 DR1: 0000000000000000 DR2: > 0000000000000000 > [ 228.219291] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: > 0000000000000400 > [ 228.219291] Stack: > [ 228.219291] 0000000000000282 7fffffffffffffff ffff88002f85de18 > 0000000100000001 > [ 228.219291] 0007ffffffffffff ffffffff811d343a ffff88002f85dc50 > ffff8800318ad470 > [ 228.219291] ffff880027bad488 0000000200000000 ffff88002f85dc40 > ffff8800318ad2c0 > [ 228.219291] Call Trace: > [ 228.219291] [<ffffffff811d343a>] ? start_this_handle+0x43a/0x4c0 > [ 228.219291] [<ffffffff8105068e>] ? current_fs_time+0x1e/0x30 > [ 228.219291] [<ffffffff810db6ec>] ? account_page_dirtied+0x8c/0xc0 > [ 228.219291] [<ffffffff8149e586>] ? _raw_spin_lock_irqsave+0x26/0x40 > [ 228.219291] [<ffffffff811d36fc>] ? jbd2__journal_start+0xcc/0x150 > [ 228.219291] [<ffffffff811a00e4>] ? ext4_da_writepages+0x274/0x480 > [ 228.219291] [<ffffffff810d0c29>] ? __filemap_fdatawrite_range+0x49/0x50 > [ 228.219291] [<ffffffff810d0caa>] ? filemap_write_and_wait_range+0x7a/0xa0 > [ 228.219291] [<ffffffff81198c47>] ? ext4_sync_file+0x47/0x270 > [ 228.219291] [<ffffffffa018f91a>] ? unionfs_fsync+0x1aa/0x270 [unionfs] > [ 228.219291] [<ffffffff810fec32>] ? SyS_msync+0x152/0x1e0 > [ 228.219291] [<ffffffff8101809a>] ? syscall_trace_enter+0x1a/0x1f0 > [ 228.219291] [<ffffffff8149f577>] ? tracesys+0xdd/0xe2 > [ 228.219291] Code: 60 e8 95 d1 f3 ff eb d7 48 89 df bb 01 00 00 00 e8 76 f7 > ff ff e9 99 fe ff ff 0f 0b eb fe 4c 89 f7 e8 15 06 f3 ff e9 20 fd ff ff <0f> > 0b eb fe 0f 0b eb fe 0f 0b eb fe 0f 1f 40 00 41 57 41 56 41 > [ 228.219291] RIP [<ffffffff8119fe60>] write_cache_pages_da+0x470/0x480 > [ 228.219291] RSP <ffff88002f85dbc8> > [ 228.304359] ---[ end trace 308e07cfd118bed3 ]--- > > > -- > James Davidson > [email protected] > http://brocade.com/ > _______________________________________________ > unionfs mailing list: http://unionfs.filesystems.org/ > [email protected] > http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs > _______________________________________________ unionfs mailing list: http://unionfs.filesystems.org/ [email protected] http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs
