On Sun, 2005-10-02 at 12:22 +0200, Hans-Peter Jansen wrote: > Hi Junjiro San, > > First of all, your patches are highly appreciated! > > Am Sonntag, 2. Oktober 2005 11:30 schrieb [EMAIL PROTECTED]: > > This is less important patch, to speed up check_empty(). > > It returns asap on the basis of the nlink of an empty dir is 2, and > > count-up his parent dir's nlink. > > I am not sure there is a filesystem doen't follow such basis. Junjiro,
Unionfs doesn't actually behave for this basis. The i_nlink is actually the *minimum* number of subdirectories. Imagine the following situation: b0 b1 .wh.dir dir i_nlink is going to be 3 for Unionfs, but the directory is indeed empty. What would be a valid speed up is if the first lower-level directory has a link count > 2, then check_empty can just return -ENOTEMPTY. Charles _______________________________________________ unionfs mailing list [email protected] http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs
