> This patch for unionfs_d_revalidate() merges two auto variables 'err'
> and 'invalid'. And also checks the return value of
> unionfs_lookup_backend() correctly.
        :::
> --- unionfs-20060208-2346/lookup.c    9 Feb 2006 13:04:42 -0000       1.1
> +++ unionfs-20060208-2346/lookup.c    10 Feb 2006 07:00:55 -0000
> @@ -320,8 +320,13 @@ int unionfs_partial_lookup(struct dentry
>       struct dentry *tmp;
>  
>       tmp = unionfs_lookup_backend(dentry, INTERPOSE_PARTIAL);
> -
> -     return PTR_ERR(tmp);
> +     if (!tmp)
> +             return 0;
> +     if (IS_ERR(tmp))
> +             return PTR_ERR(tmp);
> +     /* need to change the interface */
> +     BUG_ON(1);
> +     return -ENOSYS;
>  }

The last BUG_ON() should be
BUG_ON(tmp != dentry);
sorry.

Junjiro Okajima
_______________________________________________
unionfs mailing list
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs

Reply via email to