On Fri, Feb 10, 2006 at 05:37:13PM +0900, [EMAIL PROTECTED] wrote: > There are some problems around permission bits of a dir. For example, > unionfs cannot remove the un-writable dir while unix/posix can. And if > a dir doen't have exec bit (rare case), unionfs cannot handle it > correctly. > This patch will solve those problems.
Ok, I have two questions about this patch... > --- unionfs-20060208-2346/dirhelper.c 9 Feb 2006 13:04:42 -0000 1.1 > +++ unionfs-20060208-2346/dirhelper.c 10 Feb 2006 06:55:42 -0000 1.3 > @@ -63,41 +78,34 @@ int delete_whiteouts(struct dentry *dent [....] > fist_copy_attr_times(dentry->d_inode, hidden_dir_dentry->d_inode); > - dentry->d_inode->i_nlink = get_nlinks(dentry->d_inode); > + //dentry->d_inode->i_nlink = get_nlinks(dentry->d_inode); > Seems like a left over from during coding...Is it commented out on purpose? (There are few instances of get_nlinks getting commented out.) Also, can the function be reused elsewhere? (There are a number of places where we do the save fsuid, do_foo, restore fsuid trick.) Jeff. _______________________________________________ unionfs mailing list [email protected] http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs
