On Thu, 2006-05-11 at 10:32 -0400, Shaya Potter wrote:
> On Thu, 2006-05-11 at 10:13 -0400, Erez Zadok wrote:
> > Shaya, could you produce this mmap patch against our latest CVS snapshot,
> > which uses #ifdef UNIONFS_MMAP? It'd be easier to apply it and for others
> > to test it.
>
> eventually (i.e. if not today, it will be next week), but I was having
> issues w/ the cvs stuff, and especially needed a stable system for OSDI.
> I can make the patch against cvs again, but as cvs requires a newer
> kernel than what we're running, can't really test it.
here's the fix.
diff -rNu unionfs-20060503-0408/mmap.c unionfs-20060503-0408.fix/mmap.c
--- unionfs-20060503-0408/mmap.c 2006-05-03 04:08:06.000000000 -0400
+++ unionfs-20060503-0408.fix/mmap.c 2006-05-11 10:42:22.000000000 -0400
@@ -262,11 +262,11 @@
mark_inode_dirty_sync(inode);
out:
- /* we must set our page as up-to-date */
+ /* SP: should optimize here that if writing complete page
+ * should mark page uptodate, otherwise, require an extra call
+ * to readpage() */
if (err < 0)
ClearPageUptodate(page);
- else
- SetPageUptodate(page);
print_exit_status(err);
return err; /* assume all is ok */
}
_______________________________________________
unionfs mailing list
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs
