Hi,

using unionfs (cvs or newer snapshots) on a Fedora Core 5 system,
I get the following compile error:

cc1: warnings being treated as errors
/root/unionfs-tests/tmp/build/unionfs/mmap.c:338: warning:
initialization from incompatible pointer type

It appears that the sync_page function in struct
address_space_operations is expected to return an int,
(at least in a vanilla 2.6.16), whereas the
unionfs_sync_page function returns void.

The attached trivial patch fixes the problem.

Regards,
Torsten
--- unionfs/mmap.c.orig	2006-05-25 14:06:48.000000000 +0200
+++ unionfs/mmap.c	2006-05-25 14:07:18.000000000 +0200
@@ -304,7 +304,7 @@
 	return 0;
 }
 
-void unionfs_sync_page(struct page *page)
+int unionfs_sync_page(struct page *page)
 {
 	struct inode *inode;
 	struct inode *lower_inode;
@@ -326,7 +326,7 @@
 
       out:
 	print_exit_status(0);
-	return;
+	return 0;
 }
 
 struct address_space_operations unionfs_aops = {
_______________________________________________
unionfs mailing list
[email protected]
http://www.fsl.cs.sunysb.edu/mailman/listinfo/unionfs

Reply via email to