** Bug watch added: GNOME Bug Tracker #710882 https://bugzilla.gnome.org/show_bug.cgi?id=710882
** Also affects: vala via https://bugzilla.gnome.org/show_bug.cgi?id=710882 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Unity API bugs, which is subscribed to Bluetooth Menu. https://bugs.launchpad.net/bugs/1244468 Title: implicitly-generated variants are leaked Status in Bluetooth Menu: In Progress Status in Sound Menu: In Progress Status in Vala: Unknown Bug description: The implicitly-created GVariant is leaked in Service's volume_changed() function. We can fix it by making the variant explicit. But, should this be reported upstream as a Vala bug? One line diff: - volume_action.set_state (volume); + volume_action.set_state (new Variant.double (volume)); C code generated from "volume_action.set_state (volume)": static GVariant* _variant_new4 (gdouble value) { return g_variant_ref_sink (g_variant_new_double (value)); } static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) { ... _tmp3_ = volume; _tmp4_ = _variant_new4 (_tmp3_); g_simple_action_set_state (volume_action, _tmp4_); ... } C code generated from "volume_action.set_state (new Variant.double (volume))": static void indicator_sound_service_volume_changed (IndicatorSoundService* self, gdouble volume) { ... _tmp3_ = volume; _tmp4_ = g_variant_new_double (_tmp3_); g_variant_ref_sink (_tmp4_); _tmp5_ = _tmp4_; g_simple_action_set_state (volume_action, _tmp5_); _g_variant_unref0 (_tmp5_); ... } To manage notifications about this bug go to: https://bugs.launchpad.net/indicator-bluetooth/+bug/1244468/+subscriptions -- Mailing list: https://launchpad.net/~unity-api-bugs Post to : [email protected] Unsubscribe : https://launchpad.net/~unity-api-bugs More help : https://help.launchpad.net/ListHelp
