Hi Ralph.
A small issue (gcc 6.3.1):
Code:
--------------------
output.c: In function '_output_frames':
output.c:155:22: warning: comparison of constant '2' with boolean expression
is always false [-Wbool-compare]
if (!output.fade == FADE_ACTIVE || !output.fade_mode == FADE_CROSSFADE) {
^~
output.c:155:22: warning: logical not is only applied to the left hand side
of comparison [-Wlogical-not-parentheses]
output.c:155:58: warning: logical not is only applied to the left hand side
of comparison [-Wlogical-not-parentheses]
if (!output.fade == FADE_ACTIVE || !output.fade_mode == FADE_CROSSFADE)
--------------------
My fix:
Code:
--------------------
diff -Naur output.c.orig output.c.new
--- output.c.orig 2017-04-03 14:44:04.002246768 +0200
+++ output.c.new 2017-04-03 14:48:45.712937723 +0200
@@ -152,7 +152,7 @@
IF_DSD(
output.dop = output.next_dop;
)
- if (!output.fade == FADE_ACTIVE ||
!output.fade_mode == FADE_CROSSFADE) {
+ if (! (output.fade == FADE_ACTIVE) || !
(output.fade_mode == FADE_CROSSFADE)) {
output.current_replay_gain =
output.next_replay_gain;
}
output.track_start = NULL;
--------------------
Would be nice to introduce above.
Thx
SC
------------------------------------------------------------------------
soundcheck's Profile: http://forums.slimdevices.com/member.php?userid=34383
View this thread: http://forums.slimdevices.com/showthread.php?t=97046
_______________________________________________
unix mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/unix
