+1. It's a good idea, and a good proposed change. Getting the property names to align well with the external-to-uPortal-system-property-naming-conventions is a good move.

Andrew

Cris J Holdorph wrote:
Create a Jira ticket, you can cut/paste most of this text if you want to make it simple.

Then make the change. If you're not a committer, then post the patch/diff/modified files to the Jira ticket and request on the dev list for a committer to review the changes.

Overall I don't see a problem with what you describe, just keep in mind the default out-of-the-box should be only requiring someone to set one 'tomcat' property.

---- Cris J H

Andy Gherna wrote:
Hi all,

I was wondering if there was still some time to get a tweak in to the build
process for 2.6.  My suggestion has to do with the way the tomcat
directories are referenced. When you start Tomcat, you see 2 environment variables that get set: CATALINA_HOME and CATALINA_BASE. These point to the same directory most of
the time.  However, they can point to 2 different directories.
CATALINA_HOME should point to the base of your Tomcat install. This would
be the bin/, common/ and server/ directories at a minimum.  The
CATALINA_BASE can point to a separate set of directories that would include
the shared/, temp/, work/, and webapps/ directory.  This allows multiple
instances of tomcat (hence multiple hosts) to be running different
applications on the same machine.  See
http://www.linuxjournal.com/article/8561 for additional information.

The current deployment process is not aware of this convention. And most of the time it doesn't have to be. However, we have our tomcat instances (on our workstations and servers) set up so that we have separate CATALINA_HOME and CATALINA_BASE directories. Right now, we have only 1 directory we can set in build.properties for the deployment process (server.home). Usually we set sever.home to point to CATALINA_BASE and most of the time that's OK. But when we initialize the portal, the jars that belong in the common/ directory (lib.container-common) get copied there when they really belong under CATALINA_HOME. And then hilarity ensues as I try to remember
why this is happening...

Could there be an additional property added to the build process to help
avoid this confusion? Like could a server.base be added? Out of the box, it could (and probably for 90% of folks should) point to the same directory as the server.home. And then for those who want the separate directory for
their base can have it too.

----
Andy Gherna
University of Illinois - CITES
Sr. Research Programmer
Office: 1514 DCL
Email: [EMAIL PROTECTED]
Phone: (217) 265-9490




--
You are currently subscribed to [email protected] as: [EMAIL 
PROTECTED]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/uportal-dev

Reply via email to