The next release of uP3 will include a theme provided by Gary Thompson from Unicon that includes some neat features such as fly-out menus, lighter xhtml, and well defined and broken up XSL. While talking with him about incorporating this new theme he had some suggestions relating to structure, theme and skin file locations.
Currently layout files are in /uportal-war/src/main/resources/org/jasig/portal/layout/ with no obvious declaration of which files are for the structure or which are for the theme. I would like to simply add structure/ and theme/ directories under layout/ and move the appropriate files under each.
Similarly with skin files we currently have directories that look like /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/xhtml-theme/spring/ I would like to simplify this structure and remove the entire /org/jasig/portal/layout/tab-column/xhtml-theme/ bit and just have a skins/ directory in the base media directory, perhaps adding a common/ directory for shared js, css, images:
/uportal-war/src/main/webapp/media/common/javascript /uportal-war/src/main/webapp/media/common/css /uportal-war/src/main/webapp/media/skins/springWith both layout XSL and skins I would also like to review what we are shipping with uPortal 3 to see if the variety of XSLs and skins actually add value.
For structure transforms we currently have:/uportal-war/src/main/resources/org/jasig/portal/layout/DLM-tab-column/tab-column.xsl (this is the default in 2.6)
/uportal-war/src/main/resources/org/jasig/portal/layout/nested-categories/nested-categories.xsl /uportal-war/src/main/resources/org/jasig/portal/layout/tab-column/tab-column.xsl For theme transforms we currently have:/uportal-war/src/main/resources/org/jasig/portal/layout/DLM-tab-column/nested-tables/nested-tables.xsl (this is the default in 2.6)
/uportal-war/src/main/resources/org/jasig/portal/layout/nested-categories/deck-of-cards/deck-of-cards.xsl /uportal-war/src/main/resources/org/jasig/portal/layout/tab-column/deck-of-cards/deck-of-cards.xsl /uportal-war/src/main/resources/org/jasig/portal/layout/tab-column/nested-tables/nested-tables.xsl /uportal-war/src/main/resources/org/jasig/portal/layout/tab-column/xhtml-theme/xhtml-theme.xsl For skins we currently have: /uportal-war/src/main/webapp/media/org/jasig/portal/layout/DLM-tab-column/nested-tables/cp /uportal-war/src/main/webapp/media/org/jasig/portal/layout/DLM-tab-column/nested-tables/imm /uportal-war/src/main/webapp/media/org/jasig/portal/layout/DLM-tab-column/nested-tables/java /uportal-war/src/main/webapp/media/org/jasig/portal/layout/DLM-tab-column/nested-tables/matrix /uportal-war/src/main/webapp/media/org/jasig/portal/layout/DLM-tab-column/nested-tables/uosm /uportal-war/src/main/webapp/media/org/jasig/portal/layout/DLM-tab-column/nested-tables/vsac /uportal-war/src/main/webapp/media/org/jasig/portal/layout/nested-categories/deck-of-cards /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/nested-tables /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/xhtml-theme/grape /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/xhtml-theme/metal /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/xhtml-theme/ocean/uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/xhtml-theme/spring (this is the default in 2.6)
/uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/xhtml-theme/usflag /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tab-column/xhtml-theme/winter /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tree-column/imm /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tree-column/sun /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tree-column/usom /uportal-war/src/main/webapp/media/org/jasig/portal/layout/tree-column/vsacIf you're interested in what any of these skins look like you can usually find a thumbnail in the /skin/ folder under each:
https://www.ja-sig.org/svn/up2/trunk//uportal-war/src/main/webapp/media/org/jasig/portal/layout/DLM-tab-column/nested-tables/imm/skin/To me this seems like an overwhelming number of choices and I would bet that we really don't want all of these there as most of them are probably bad examples especially in light of the work Gary is doing. I would like to propose to remove at least the following files:
All /tab-column/ structure and theme files. All /DLM-tab-column/ skinsAll /tree-column/ skins since we don't appear to ship a theme transform to even generate tree column.
With the addition of the new theme for uP3 we would be using /uportal-war/src/main/resources/org/jasig/portal/layout/DLM-tab-column/tab-column.xsl The new xhtml theme XSL The new xhtml theme skin filesDocumentation would be provided on how to switch back to the 2.6 nested-tables.xsl and spring skin and the currently available skins for the theme would still be availble. We would still be including the nested-categories and the deck-of-cards themes as demos of other ideas for themes UIs.
I know this is a long email but _any_ feedback you have about this would be very much appreciated.
-Eric
smime.p7s
Description: S/MIME Cryptographic Signature
