The clean command works the same way as it has since at least 2.3 (furthest back I checked) such that running clean deletes the ${deploy.home} directory. That said I think we should review the ant commands available and perhaps refactor them a bit for 3.1 as well as some of the default settings.

removeExisting property (build.properties):
This defaults to false right now but we should probably change it to true. Functionally if this property is true the WAR deployer functionality will remove the existing .war or webapp folder when deploying the webapp. This helps avoid having orphaned files deployed to the container.

clean target:
This has been brought up a few times now, primarily the fact that clean deletes the webapp from tomcat. I think we can change that and perhaps add a 'clean-deployed' target to allow people to continue using the functionality if the need it.

It also sounds like we should standardize the user based commands to take the same paramters.


Are there other changes people would like to see to the uPortal 3.1 ant targets?



Current 'public' ant targets in the trunk (found via ant -p):

addstylesheet        Registers a new theme or structure
clean Removes the deployed uPortal from the container and runs 'mvn clean'
clean-shared         Removes the ALL shared libraries from the container.
crn-delete           Deletes the specified entity
crn-export Exports the specified entity or entities to XML on the file system
crn-import           Imports the specified XML file or files
crn-make-data-xml Runs the DbUnload tool against all tables listed in data.xml
db                   Loads database tables and data
db-hibernate         Drops then creates Hibernate managed tables
db-hibernate-portal Drops then creates Hibernate managed tables for the portal db-hibernate-stats Drops then creates Hibernate managed tables used for the database backed portal statistics
db-import            Imports the default XML files to the database
dbtest Displays information about the database defined in rdbm.properties
dbunload             Dumps a database table to a flat file in XML format
delstylesheet        Deletes an existing theme or structure
deluser              Delete traces of a user from the portal database
deploy-ear Deploy uPortal and dependent libraries and portlets to the servlet container deploy-war Deploy the uPortal web application to the servlet container
deployPortletApp     Deploys a portlet application
help                 Prints information about using this ant build file.
hsql Start a HSQLDB instance consistent with the default RDBMS requirements of uPortal hsql-shutdown Compacts then cleanly shuts down hsql, useful if the 'hsql' task was run with '-Dspawn=true'
i18n-db              Loads internationalization tables and data
initdb Drops all tables, then runs all the targets necessary prepare the portal database initportal Runs all the targets necessary to deploy the portal and prepare the portal database
md5passwd            Creates a user in the UP_PERSON_DIR table
modstylesheet        Modifies an existing theme or structure
regchantype          Registers a new channel type


Arlo White wrote:
I had a few comments on the build.xml file in uPortal trunk.

ant clean removes the destination directory. This is bound to bite someone who's used to 2.5's ant clean being like mvn clean. ant clean should run mvn clean.

ant deluser uses a different parameter than ant md5passwd: deluser uses 'user', md5passwd uses 'username'. They should use the same parameter format. Also if you don't specify the parameter the error is rather cryptic and makes you think the user doesn't exist rather than you typed the wrong parameter name.

Would you like me to add JIRA issues for these or create a patch, or should I let a main developer do it?


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to