I'm finally getting around to looking at the change.

-FragmentDefinitionDao should probably be defined by an interface so that code that references such as RDBMConfigurationLoader are using an interface, this is especially import as there are several aspects applied to DAOs that are can not get applied to this DAO due the lack of an interface.

Other than that I think it looks pretty good. I think the DLM internals will eventually need a more complete rewrite but that is a much larger task for a later date.

PS: How do I switch to the new code?

-Eric

Drew Wills wrote:
Hey folks,

Today I wrote up a JIRA and posted a patch that enables DLM fragment definitions to be stored in the database, instead of defined in dlm.xml. The motivation for this enhancement is to allow DLM fragment definitions to be added, removed, or altered without a portal restart. This is an important requirement for the Pearson Curriculum team, and they sponsored the work.

The persistence stack is JPA/Hibernate/Spring/ehcache -- just like the recent portlet preferences API.

Please take a look at the JIRA for a pretty detailed description of the approach (though JIRA's having troubles atm): https://www.ja-sig.org/issues/browse/UP-2282

This enhancement makes the new tech optional: you can run either the new code or the old code. If you don't specify either way, you get the old code.

I'm hoping to get this in for 3.1.

drew wills

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to