Re: [uportal-dev] Potential issue with DLM in uPortal 3.1

[Eric Dalquist]

Looks like there was a bug in the Paren code introduced with the JPA storage option refactoring. The code was doing String.equals(ParenType) which always returned false. I replaced ParenType with a enum named Type inside the Paren class and updated the logic to deal with that. I also switched the internal type field from a String to a Type. I don't know if this break the JPA storage option since there aren't any unit tests for it.

Thanks,
-Eric

Jen Bourey wrote:

Drew could you review the JPA storage option and potentially add some basic unit tests?

Hi all,



Any ideas?

- Jen
--

You are currently subscribed to uportal-dev@lists.ja-sig.org as: 
eric.dalqu...@doit.wisc.edu
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/uportal-dev

I've noticed that some of the DLM fragments don't seem to be appearing properly in the current uPortal trunk. Although the guest-lo fragment is imported correctly for the guest user, it seems like no fragments appear for logged in users. I'm not sure if this is related to the user being authenticated, or maybe a result of nested elements not being evalutated correctly. From a look at dlm.xml, it looks like the guest-lo fragment is the only one that doesn't have nested <paren> elements.

smime.p7s
Description: S/MIME Cryptographic Signature