Good catch - fix is checked into trunk. On Thu, Nov 19, 2009 at 10:40 PM, Susan Bramhall <[email protected]> wrote: > I am attempting to add additional info messages to the deploy ear mojo to > track down problems we are having with maven plugin and discovered that the > tests in M2 and trunk fail for me. The issue is that the hard coded > filenames in ResourcesAggregatorImplTest do not match the names generated > when I run the test. It looks they are using some sort of guid which is not > always the same on every machine. I changed the Assert statements in > question to use the file names in the lists returned from > ResourceAggregatorImpl. Not sure if this tests what you intend but it > passes. Patch is below. > Susan > ======patch===== > Index: > src/test/java/org/jasig/portal/web/skin/ResourcesAggregatorImplTest.java > =================================================================== > --- > src/test/java/org/jasig/portal/web/skin/ResourcesAggregatorImplTest.java > (revision 47213) > +++ > src/test/java/org/jasig/portal/web/skin/ResourcesAggregatorImplTest.java > (working copy) > @@ -154,13 +154,13 @@ > Assert.assertEquals(6, cssList.size()); > List<Js> jsList = result.getJs(); > Assert.assertEquals(1, jsList.size()); > - Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/common/css/fluid/uportal3_aggr1_A3661D3474000B0B06BC01EA644DBE07.css").exists()); > - Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/common/css/uportal3_aggr2_0A62110C5DBE25EECD978B41EE455466.css").exists()); > - Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/common/css/uportal3_aggr2_0A62110C5DBE25EECD978B41EE455466.css").exists()); > - Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/uportal3/uportal3_aggr3_3334333FF8A41D7D6BCE5C8AE5B71B4A.css").exists()); > - Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/uportal3/uportal3_aggr5_0EC69539BB6BA6C8B611BAC539C67794.css").exists()); > - Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/uportal3/uportal3_aggr6_F21DFDA90E2DFAEB81BC098A037A458C.css").exists()); > - Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/common/javascript/uportal/uportal3_aggr7_158C92140AC7355300F2708F20D66DB2.js").exists()); > + > + Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/common/" + cssList.get(0).getValue()).exists()); > + Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/common/" + cssList.get(1).getValue()).exists()); > + Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/uportal3/" + cssList.get(2).getValue()).exists()); > + Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/uportal3/" + cssList.get(4).getValue()).exists()); > + Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/uportal3/" + cssList.get(5).getValue()).exists()); > + Assert.assertTrue(new File(getTestOutputRoot() + > "/skin-universality/common/" + jsList.get(0).getValue()).exists()); > } > > /** > > -- > > Susan Bramhall ([email protected]) > Senior Developer, Infrastructure Systems and Architecture (formerly T&P) > Yale University Information Technology Services (ITS) > 25 Science Park, 150 Munson St, New Haven, CT 06520 > Phone: 203 432 6697 > > -- > > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev
-- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
