We'd actually already addressed most of that issue a few weeks ago by introducing a new "defaultTab" parameter. We still need to wire in the user interface for setting it, as well as address it in import/export. The ticket is here if you'd like to follow it: https://issues.jasig.org/browse/UP-2728.
- Jen On Aug 3, 2010, at 6:50 AM, Susan Bramhall wrote: > Eric, I think your structure XSL change may have also fixed a long standing > bug where the active tab was sometimes persisted incorrectly causing the > saved active tab to be the active tab after login - forever. I couldn't find > this bug so I had to disable the persistence of that attribute at Yale to > prevent this behavior. I can't test trunk right now but maybe you or Jen > could run the following additional test? > Add a pre-made tab > move the newly added tab to the left one or two positions > logout > login > If you are correctly positioned on the first tab, the bug is fixed. If the > bug is there, you will be positioned on the newly added tab. > Have we now officially removed the ability for a user to indicate that a > certain tab should be the default active tab (at login)? > Susan > > Eric Dalquist wrote: >> >> So Jen's fix is in for all the skins. >> >> Also tab navigation should work for user owned tabs as well as DLM merged >> tabs. For this I changed how the structure XSL parameters work. The >> 'activeTab' XSL parameter is no longer used, instead focusedTabID is used >> and the actual ID of the tab being navigated to is set. This works much >> better with the new URL syntax where the tabId is part of the URL. >> >> I also updated the image portlet to support Spring Expression Language >> (SPEL) for the portlet preferences. The use case for this is some of the >> local images that need to reference to the context path. If you're interest >> in the change take a look at: >> https://developer.jasig.org/source/changelog/jasigsvn/?projectKey=UP&cs=21383 >> >> >> -Eric >> >> On 7/30/10 11:45 AM, Eric Dalquist wrote: >>> I'm seeing the same Add Tab JS error. I just created >>> https://issues.jasig.org/browse/UP-2766 >>> >>> -Eric >>> >>> On 7/28/10 3:14 PM, Jennifer Bourey wrote: >>>> In my current checkout, I can add a new tab, but once that tab is added >>>> I'm redirected back to the first tab in my layout. I think the issue >>>> right now is actually that one can't successfully access a custom >>>> (non-fragment) tab. >>>> >>>> - Jen >>>> >>>> >>>> On Jul 28, 2010, at 12:19 PM, Eric Dalquist wrote: >>>> >>>>> Jen, have you tested the Add Tab link yet in trunk? >>>>> >>>>> -Eric >>>>> >>>>> On 7/28/10 12:00 PM, Vangel V. Ajanovski wrote: >>>>>> On 07/27/2010 02:23 AM, Eric Dalquist wrote: >>>>>> >>>>>>> Trunk is NOT stable for doing portlet development on. If you'd like to >>>>>>> help test new features you are more than welcome, as you run into >>>>>>> issues report them here with a full stack trace and then we can see if >>>>>>> we need a Jira issue to track it or not. >>>>>>> >>>>>> I realize that trunk is not stable but I am just running experiments for >>>>>> a future portal so I figured to test from trunk. >>>>>> >>>>>> Today everything seems to have settled and I managed to start the >>>>>> portal, customize it a bit, except for the "Add tab" link which does not >>>>>> work - meaning that when I click it nothing happens. I can change skin, >>>>>> change layout, add content, but cannot add tabs. >>>>>> >>>>>> I don't have exceptions in the logs so it seems some kind of a script >>>>>> issue. >>>>>> So I checked the browser and I got many warnings and only one error and >>>>>> it mentions tabs so it might be applicable to the problem. >>>>>> >>>>>> JavaScript - >>>>>> http://develop.ii.edu.mk:8080/uPortal/render.userLayoutRootNode.uP >>>>>> >>>>>> Uncaught exception: TypeError: 'uportal.PageManager' is not a function >>>>>> Error thrown at line 1, column 1350 in<anonymous function: >>>>>> a.uportal.UportalLayoutManager>(): >>>>>> >>>>>> uportal.PageManager("#pageLayoutDialog",{currentPageName:a("#tabLink_"+z.tabId+" >>>>>> >>>>>> >>>>>>> >>>>>> span").text(),isDefault:true,currentLayout:n(),savePermissionsUrl:z.preferencesUrl,imagePath:z.mediaPath+"/"+z.currentSkin+"/images/",selectors:{},listeners:{onUpdateLayout:x,onUpdatePageName:p,onUpdateIsDefault:null}}); >>>>>> >>>>>> called from line 2, column 3549 in<anonymous function: >>>>>> a.uportal.UportalLayoutManager>(f): >>>>>> A(); >>>>>> called from line 5, column 10 in<anonymous function>() in >>>>>> http://develop.ii.edu.mk:8080/uPortal/render.userLayoutRootNode.uP: >>>>>> up.jQuery.uportal.UportalLayoutManager( >>>>>> called from line 26, column 460 in<anonymous function: ready>(): >>>>>> a.call(s,c); >>>>>> called via Function.prototype.call() from line 33, column 235 in >>>>>> <anonymous function: L>(): >>>>>> c.ready() >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>> >>> >> > > -- > Susan Bramhall ([email protected]) > Senior Developer, Infrastructure Systems and Architecture > Yale University Information Technology Services (ITS) > 25 Science Park, 150 Munson St, New Haven, CT 06520 > Phone: 203 432 6697 > > -- > > You are currently subscribed to [email protected] as: > [email protected] > To unsubscribe, change settings or access archives, see > http://www.ja-sig.org/wiki/display/JSG/uportal-dev -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
