I don't think there are any problems with this. We've been trying to be careful with 'static' portlets in layouts to cut down on orphaned portlet rendering errors. This is caused when a portlet is included in the header or footer but is never referenced in the theme. The portal starts rendering the portlet after the structure transformation but since the theme never copies over the reference the rendering thread is never joined. This is how you get rouge errors about HttpSession being null or other weird things talking about invalid request state. uP4 is better about this and gives you an explicit message about the orphaned rendering thread but you still get the error.

So in short, putting it in the default layout is fine as long as the default structure and theme result in the content being included in the final output for users that are authorized to see the portlet.

-Eric

On 10/11/11 6:52 AM, Carroll, Timothy Dale wrote:
That sounds right to me. Can we consult the individual who made the commit that removed it? Perhaps it truly was an mere oversight. If not, we should understand the reasoning. Tim


On Oct 11, 2011, at 1:28 AM, Steve Swinsburg wrote:

I think the fragment-admin channel needs to be re-added to the defaultTemplateUser layout in the 3.2 branch.

I added this locally and everything is working as expected. I think this is the solution and should be committed to the 3.2 branch. Any objections?

regards,
Steve



On 11/10/2011, at 3:52 PM, Steve Swinsburg wrote:

Hi Tim,

It does, thanks!

However I note that the 3.2 version of portal.properties is set like:

org.jasig.portal.services.Authentication.defaultTemplateUserName=defaultTemplateUser

And defaultTemplateUser already has a layout.

But what was odd is that in https://issues.jasig.org/browse/UP-2895 the fragment-admin channel was removed from the defaultTemplateUser layout. I think that might have been erroneous. You can see what was removed in the patch attaced to that Jira (I made it based on the commit since the source viewer was down)

So effectively the fragment-admin channel isn't on any layout in 3.2 branch (except for the fragment owner template but that is no good here since you'd already need to be the fragment owner to start with).

Does the defaultTemplateUser layout get propagated to all users as a kind of starting point? If so, I think the fragment-admin channel needs to be re-added to the defaultTemplateUser layout in the 3.2 branch.

cheers,
Steve




On 11/10/2011, at 1:52 PM, Carroll, Timothy Dale wrote:

Steve.  We are still on 3.1.1, but here is how we have this setup...

First, we created two template users guest-usr and empty-usr. The guest-usr layout has the login channel in the header and maybe a couple other things. The empty-usr layout looks like this...

<layout script="classpath://org/jasig/portal/io/import-layout_v3-0.crn" username="empty-usr">
<root unremovable="Y" immutable="N" hidden="N" name="Root folder">
<header unremovable="Y" immutable="Y" hidden="N" name="Header folder">
<channel unremovable="" immutable="" hidden="" fname="header"/>
<channel unremovable="" immutable="" hidden="" fname="portal/login/general"/> <channel unremovable="" immutable="" hidden="" fname="session-locales-selector"/>
<channel unremovable="" immutable="" hidden="" fname="fragment-admin"/>
</header>
<footer unremovable="N" immutable="N" hidden="N" name="Footer folder">
<channel unremovable="" immutable="" hidden="" fname="footer"/>
</footer>
</root>
<profile name="HTML browser profile">
<description>A sample profile for common web browsers</description>
<structure name="DLM Tabs and columns"/>
<theme name="DLM XHTML"/>
</profile>
</layout>


then, in portal.properties we reference that empty-usr here:
org.jasig.portal.services.Authentication.defaultTemplateUserName=empty-usr

does this help?
tc



On Oct 10, 2011, at 10:23 PM, Steve Swinsburg wrote:

An update. This *doesn't* work on the up32 branch code (when logged in as admin), I was looking at an out of date db.

So the problem is that the fragment-admin channel is not added to the layout.

Would adding it to the defaultTempalteUser.layout fix this for all users? Is that the goal of the allowExpandedContent parameter in DLM? Or should this channel (and any others) be added to the template owners layouts (ie student-lo etc)

regards,
Steve



On 11/10/2011, at 1:08 PM, Steve Swinsburg wrote:

Hi all,

We are having an issue where the fragment-admin link on the right hand nav won't show up.

We've patched uPortal 3.2.4 up to the latest 3.2.5 branch and along with it came the mod from this issue: https://issues.jasig.org/browse/UP-2895

...which essentially removes the cruft from the header and footer folder of the layout templates, but specifically removing fragment-admin channel from the defaultTemplateUser.layout

I presume that removing this from defaultTemplateUser means it won't be added in the header of a user's layout? How then does it ever get added? I think this is to do with a modification we've made somewhere since it works fine on the pristine 3.2.5 branch code, but I'm at a loss as to where I should look as all of the layout code we have is identical to the branch. And the statement in universality.xsl that is meant to add it to the page is still the same as:

<!-- Fragment Administration -->
<xsl:copy-of select="//channel[@fname = 'fragment-admin']"/>

If a user navigates directly to the portlet then it works:
/uPortal/render.userLayoutRootNode.uP?uP_fname=fragment-admin

Any tips?

regards,
Steve



--

You are currently subscribed [email protected]  
<mailto:[email protected]>  as:[email protected]  
<mailto:[email protected]>
To unsubscribe, change settings or access archives, 
seehttp://www.ja-sig.org/wiki/display/JSG/uportal-dev

--

You are currently subscribed [email protected]  
<mailto:[email protected]>  as:[email protected]  
<mailto:[email protected]>
To unsubscribe, change settings or access archives, 
seehttp://www.ja-sig.org/wiki/display/JSG/uportal-dev


--

You are currently subscribed [email protected]  
<mailto:[email protected]>  as:[email protected]  
<mailto:[email protected]>
To unsubscribe, change settings or access archives, 
seehttp://www.ja-sig.org/wiki/display/JSG/uportal-dev

--

You are currently subscribed to [email protected] as: 
[email protected]
To unsubscribe, change settings or access archives, see 
http://www.ja-sig.org/wiki/display/JSG/uportal-dev

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to