As it turns out, a whole chuck of DOM manipulation of the page can be removed also which speeds things up a bit between changing the layout and refreshing the page. Previously there was about a 0.5-1.0 second delay while it rewrote the DOM. That is all unnecessary now. I will update the Jira.
cheers, Steve On 28/10/2011, at 1:15 AM, Eric Dalquist wrote: > It sounds like a good solution to me :) > > On 10/27/11 9:03 AM, Bruce Tong wrote: >> I don't know very much about that part of uPortal and I don't feel I'm >> able to comment with any confidence on the technical merits of the >> patch. If you were to tell me it's the best way, then I'd believe you. >> If others disagree, the patch at least provides a work-around until >> the issue is completely resolved. >> >> On Thu, Oct 27, 2011 at 9:07 AM, Steve Swinsburg >> <[email protected]> wrote: >>> Thanks for the verification. It works after you refresh the page as it gets >>> redrawn with the correct info from columns.xsl - its just in the Javascript >>> that generates the page which is missing out form adding the required class. >>> >>> In the Jira I attached a patch that refreshes the page after changing the >>> layout. This seems to resolve the problem. What are your thoughts on this >>> approach? >>> >>> cheers, >>> Steve >>> >>> >>> >>> On 27/10/2011, at 11:51 PM, Bruce Tong wrote: >>> >>>> I saw this problem once too when giving a demo. Now that you've >>>> mentioned it, I tried to recreate it and was successful. You don't >>>> need to add a tab, just change the column layout and then try to add a >>>> portlet. >>>> >>>> On Thu, Oct 27, 2011 at 1:45 AM, Steve Swinsburg >>>> <[email protected]> wrote: >>>>> Hi all, >>>>> >>>>> We are experiencing an issue after upgrading to 3.2.5 where if you add a >>>>> tab, change the column layout and then immediately attempt to add a >>>>> portlet to it, you receive a error saying the columns are locked. >>>>> >>>>> This also affects the rel_3-2-patches branch. >>>>> >>>>> I have documented this here: https://issues.jasig.org/browse/UP-3233 >>>>> >>>>> The issue is that the canAddChildren class is not added to the markup so >>>>> the Javascript thinks there are no columns that are unlocked and returns >>>>> the error. >>>>> >>>>> We actually have a patch to correct this by simply adding a refresh to >>>>> the Javascript that draws the new layout as when it is rendered via >>>>> columns.xsl it is correct - in a similar way that adding a new tab >>>>> refreshes the page and takes you to the tab. >>>>> >>>>> Could I get some eyes on this fix? >>>>> >>>>> cheers, >>>>> Steve >>>>> >>>>> >>>>> -- >>>>> You are currently subscribed to [email protected] as: >>>>> [email protected] >>>>> To unsubscribe, change settings or access archives, see >>>>> http://www.ja-sig.org/wiki/display/JSG/uportal-dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Bruce Tong >>>> Software Engineer >>>> Office of Information Technology >>>> Ohio University >>>> >>>> -- >>>> You are currently subscribed to [email protected] as: >>>> [email protected] >>>> To unsubscribe, change settings or access archives, see >>>> http://www.ja-sig.org/wiki/display/JSG/uportal-dev >>> >>> -- >>> You are currently subscribed to [email protected] as: >>> [email protected] >>> To unsubscribe, change settings or access archives, see >>> http://www.ja-sig.org/wiki/display/JSG/uportal-dev >>> >>> >> >> > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
