Sorry, I meant to reply to this.The problem is the spec PDF and the JavaDocs aren't perfectly clear. In PLT.17.1 the spec says "Preference attributes are String array objects. Preferences attributes can be set to null"
I agree with the change on line 154 <https://github.com/Jasig/uPortal/pull/78/files#L0L154>If there is no values array set the default value should be returned. This should fix the problem you had of defining a preference with not values in the portlet.xml.
However the change on line 157 <https://github.com/Jasig/uPortal/pull/78/files#L0L157> would break the preferences object according to the spec as it would prevent a portlet from correctly storing null in the first element of the preference values array.
I will apply the first change before 4.0.7 is cut. -Eric On 10/8/12 4:43 AM, Arvīds Grabovskis wrote:
Jumping in the last moment, but I hope that you could review this <https://github.com/Jasig/uPortal/pull/78> pull request and apply it to trunk and 4.1.patches.-- Arvīds2012/10/6 Eric Dalquist <[email protected] <mailto:[email protected]>>I'm back getting actual work done and will plan on cutting 4.0.7 monday. I reviewed all changes on master and merged what I thought applied back to 4.0-patches. I'll be going through Jira tonight to see if there is any low-hanging fruit and then plan on cutting the release Monday. I'll also be cutting a new resource server release on Sunday so if anyone has any changes be sure to get them in. -Eric -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
smime.p7s
Description: S/MIME Cryptographic Signature
