Since not much actually inherits down to the subprojects (they all have
to specify their licensing, build profiles, etc. anyway as far as I
understand -- please educate me if I'm wrong) I don't see much value
either. +1 for splitting it up or just abandoning it. If my
understanding of how little does migrate into subprojects is correct, I
don't see much value in uPortal and portlets having a common parent either.
James Wennmacher - Unicon
480.558.2420
On 09/02/2014 08:36 AM, Andrew Petro wrote:
CH> I suggest, that this jasig-parent-pom dependency is one that neither
project really needs.
Sounds good to me. I¹d +1 a Pull Request freeing uPortal master from
depending on this well-intentioned but ultimately not-worth-its-weight
dependency. Care to proffer one?
Kind regards,
Andrew
PS: I still favor moving jasig-parent to GitHub. Retiring SVN has value.
Retiring unneeded stuff as value. They¹re not incompatible efforts. Just
Œcuz something is in GitHub doesn¹t mean it has to be alive and under
continued development.
On 9/2/14, 9:34 AM, "Cris J Holdorph" <[email protected]> wrote:
Why is it needed at all?
What settings exist in the jasig parent pom that uPortal and cas truly
need to share?
I just took at look at it, and I don't see very much, if anything in
that file that both CAS and uPortal need to be on the same version with,
except for one item, which is wrong as it is.
For example. You might say that "organization" should be shared.
However, the organization is no longer jasig it's Apereo.
You might say well, it's convenient to define some of the plugins,
maybe, but do we have to have two projects on the same version of those
plugins? For example, the "maven-compiler-plugin" is set at building
for JDK 1.6. I could see a real need for projects to have that set to
different values. And if they override it, then they are not gaining
value by it being defined in the parent.
I bring this up, because as we've seen dependency management and maven
are sometimes (often?) painful. And unless it's absolutely required,
reducing the number of dependencies a project has can be beneficial. I
suggest, that this jasig-parent-pom dependency is one that neither
project really needs.
---- Cris J H
On 09/01/2014 11:35 PM, Misagh Moayyed wrote:
uPortal/CAS developers,
I am wondering if it makes sense for us to move the jasig-parent project
off of SVN and over to Github. Since both CAS and uPortal (and possibly
plenty of other projects) inherit from the parent pom, it seems
reasonable to move the project off of SVN and over to Github to allow
more visibility for the changes that go into it. Specifically, I would
like to attempt to tweak the maven site plugin configuration, update
some dependencies and see if we can get a better performance out of the
plugin, and it would be better if I could do that in context of the pull
request.
Objections? Suggestions?
Misagh
--
You are currently subscribed to [email protected] as:
[email protected]
To unsubscribe, change settings or access archives, see
http://www.ja-sig.org/wiki/display/JSG/uportal-dev
--
You are currently subscribed to [email protected] as:
[email protected]
To unsubscribe, change settings or access archives, see
http://www.ja-sig.org/wiki/display/JSG/uportal-dev
