Developers, Under Semantic Versioning, whether a given changeset gives rise to a major or minor version bump depends whether the changes break an existing API.
If they do, that¹s a Major release, not a minor release. If they break no APIs and only add features within existing APIs, great, that¹s a minor release. Eyeballing the changeset, looks like Semantic Versioning would class this API-breaking and thus a Major version bump. https://github.com/Jasig/CoursesPortlet/pull/14/files Just on quick skim: * public class CourseRequirementWrapper methods disappeared * API defined in course-catalog.xsd changed in breaking ways Note that Semantic Versioning isn¹t about value judgements about change sets. Changing APIs to give rise to a new Major version isn¹t good or bad, it just is, and Semantic Versioning communicates that that amount of change has happened. This is a big changeset and it technically breaks APIs. Call it, modulo any cleanup and additional feature merges between now and release, Courses Portlet v. 2.0, and celebrate the step forward for the open source product. Kind regards, Andrew On 10/20/14, 10:11 AM, "Jim Helwig" <[email protected]> wrote: >I think that is consistent with semantic versioning, right? > >JimH > >On Oct 20, 2014, at 9:00 AM, Tim Levett <[email protected]> wrote: > >> (moving over to dev to chat quickly about minor release of courses >>portlet) >> >> Nice work Mike & team! I'm sure people are very excited for these >>enhancements. >> >> Since there was a model change it would be good to cut a minor release. >> >> What say the people? >> >> Tim Levett >> tim.levettATwisc.edu >> MyUW-Infrastructure >> >> >> ________________________________________ >> From: [email protected] >><[email protected]> on behalf of Mike Farnham >><[email protected]> >> Sent: Friday, October 17, 2014 7:05 PM >> To: [email protected] >> Subject: [uportal-user] Courses Portlet pull request merged >> >> The University of Wisconsin-Madison has contributed back the extensive >> changes we have added to the Courses Portlet. >> I do say extensive because the commit includes 153 changed files with >> 8,335 additions and 714 deletions. >> >> We apologize for the "pig through the python" approach. >> >> We have did update the model. >> We did our best to insure the changes work with the existing code. >> We have included mock data for the changes we've made >> so you can run the code "out-of-the-box", in uPortal. >> >> I think most interest has been peaked by the Class Schedule Grid >> which relies heavily on the jquery.timetable.js project. >> >> best regards, >> Mike >> >> -- >> Mike Farnham >> Information Systems Specialist >> DoIT Academic Technology >> University of Wisconsin-Madison >> (608) 262-4210 >> https://www.doit.wisc.edu/about/organization/academic-technology/ >> >> >> --- >> You are currently subscribed to [email protected] as: >>[email protected] >> To unsubscribe, change settings or access archives, see >>http://www.ja-sig.org/wiki/display/JSG/uportal-user >> >> -- >> You are currently subscribed to [email protected] as: >>[email protected] >> To unsubscribe, change settings or access archives, see >>http://www.ja-sig.org/wiki/display/JSG/uportal-dev >> > -- You are currently subscribed to [email protected] as: [email protected] To unsubscribe, change settings or access archives, see http://www.ja-sig.org/wiki/display/JSG/uportal-dev
